document why not having shims is good#433
Open
grosser wants to merge 1 commit intopostmodern:masterfrom
Open
Conversation
|
❤️ |
Owner
Contributor
|
Those commits don't mention the performance cost of shims though, so it seems a separate concern. |
|
Had another look at this and I've changed my mind. @postmodern I think the time it takes for the shim to execute is dependent on the system architecture and might involve binaries? If I'm right, then it feels to me like this is something that would be better off treated as an add-on, maybe by providing a hook for plug-ins. @eregon It would be nice to include some real-world figures in the docs, but surely that would have to mention the system specifications? The laws of nature and mathematics would tell us that a single number isn't statistically meaningful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I came here from rbenv/rbenv#1223